ci: baseline semver-checks against origin/main instead of crates.io#424
Merged
Conversation
yulnr
approved these changes
May 18, 2026
yulnr
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch the
Semver checksCI job to use--baseline-rev origin/maininstead of the default crates.io baseline.Why
By default,
cargo-semver-checkscompares the PR against the latest crates.io release. That's good for "must I bump major before publishing?" but noisy for per-PR review:--baseline-rev origin/mainmakes the per-PR check report only what the PR itself introduces. The "must I bump major?" check is already separately handled at release time byrelease-plz's ownsemver_check = true(per CONTRIBUTING.md), so we don't lose any release safety.Changes
actions/checkout:fetch-depth: 0(need full history for the baseline rev).cargo semver-checks: add--baseline-rev origin/main.Reference: https://github.com/obi1kenobi/cargo-semver-checks#does-the-crate-im-checking-have-to-be-published-on-cratesio
Expected effect on this PR
This PR itself touches only
.github/workflows/ci.yml, so the new semver-checks job has nothing to compare and should pass.